Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest-aiohttp development dep to svi_client #218

Merged
merged 2 commits into from
May 19, 2023

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented May 17, 2023

fixes #217

Additions

  • Adds pytest-aiohttp development dependency to svi_client

Testing

  1. Verified that this resolves locally RuntimeError: There is no current event loop in thread 'MainThread'. thrown in slow unit tests.

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

fixes:
RuntimeError: There is no current event loop in thread'MainThread'.
@aaraney
Copy link
Member Author

aaraney commented May 18, 2023

Weird, looks like a NWMFileProcessor test is failing.

@aaraney
Copy link
Member Author

aaraney commented May 18, 2023

Looks like the xarray.backends.plugins.list_engines function is throwing a exception because an EntryPoints object doenst have a method im assuming it previously had. Im going to throw this into its own issue and track it there.

@jarq6c jarq6c merged commit f21f04a into NOAA-OWP:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Run Slow Unit Tests" Action has been failing for some time
2 participants