Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1pt] PR: Updates for pkgs pillow, idna and openpynx #1114

Merged
merged 14 commits into from
Apr 15, 2024

Conversation

RobHanna-NOAA
Copy link
Contributor

@RobHanna-NOAA RobHanna-NOAA commented Apr 9, 2024

Two recent dependabot PR's came in, one for upgrading the pillow package and the other for upgrading idna. Both have been adjusted in this PR.
In this PR, we also moved openpyxl package, which was part of an independent dockerfile, Pipfile and Pipefile.lock in the "dev" directory. This is now merged into the parent standard docker image.

Covers PR 1111
Covers PR 1119

A small update to the README.md was also updated for an unrelated topic (about AWS S3 credentials).

Changes

  • Pipfile / Pipefile.lock: As described above.
  • data/ble/ble_benchmark/README.md: Updated notes to remove talking the specific ble docker image.

Removals

  • data/ble/ble_benchmark
    • Dockerfile: removed in favor the parent root Docker files.
    • Pipfile: removed in favor the parent root Docker files.
    • Pipfile.lock : removed in favor the parent root Docker files.

Testing

  • Created a test new docker image, opened it up and ran fim_pipeline on 05030104. I did not test the code for creating, preprocessing benchmark data. Testing for that will come later and can not reasonably be tested here.

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • Passes all unit tests locally (inside interactive Docker container, at /foss_fim/, run: pytest unit_tests/)
  • n/a - New functions are documented (with a description, list of inputs, and expected output)
  • n/a - Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Reviewers requested
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@RobHanna-NOAA RobHanna-NOAA self-assigned this Apr 9, 2024
@RobHanna-NOAA RobHanna-NOAA added Med Priority dependencies Pull requests that update a dependency file FIM4 labels Apr 9, 2024
@RobHanna-NOAA RobHanna-NOAA marked this pull request as ready for review April 9, 2024 23:59
@RobHanna-NOAA RobHanna-NOAA requested a review from mluck April 9, 2024 23:59
@RobHanna-NOAA RobHanna-NOAA changed the title [1pt] PR: Add pkgs pillow and openpynx moved [1pt] PR: Updates for pkgs pillow, idna and openpynx Apr 15, 2024
@CarsonPruitt-NOAA CarsonPruitt-NOAA merged commit adb6e36 into dev Apr 15, 2024
1 check passed
@CarsonPruitt-NOAA CarsonPruitt-NOAA deleted the dev-pillow-openpyxl branch April 15, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file FIM4 Med Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants