-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1pt] PR: Updates for pkgs pillow, idna and openpynx #1114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobHanna-NOAA
added
Med Priority
dependencies
Pull requests that update a dependency file
FIM4
labels
Apr 9, 2024
RobHanna-NOAA
changed the title
[1pt] PR: Add pkgs pillow and openpynx moved
[1pt] PR: Updates for pkgs pillow, idna and openpynx
Apr 15, 2024
CarsonPruitt-NOAA
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two recent dependabot PR's came in, one for upgrading the
pillow
package and the other for upgrading idna. Both have been adjusted in this PR.In this PR, we also moved
openpyxl
package, which was part of an independent dockerfile, Pipfile and Pipefile.lock in the "dev" directory. This is now merged into the parent standard docker image.Covers PR 1111
Covers PR 1119
A small update to the README.md was also updated for an unrelated topic (about AWS S3 credentials).
Changes
Pipfile / Pipefile.lock
: As described above.data/ble/ble_benchmark/README.md
: Updated notes to remove talking the specific ble docker image.Removals
data/ble/ble_benchmark
Dockerfile
: removed in favor the parent root Docker files.Pipfile
: removed in favor the parent root Docker files.Pipfile.lock
: removed in favor the parent root Docker files.Testing
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally/foss_fim/
, run:pytest unit_tests/
)4.x.x.x
Merge Checklist (For Technical Lead use only)