Tests failing for last merge

[ZacharyWills]

Short description explaining the high-level reason for the new issue.

Current behavior

Tests run but fail

[----------] 1 test from ForcingTest
80
[ RUN ] ForcingTest.TestForcingDataRead
81
/home/Z/actions-runner/_work/_temp/1ac2add5-d50d-471a-994c-51763b638d59.sh: line 1: 5313 Segmentation fault (core dumped) ./cmake_build/test/test_all
82
##[error]Process completed with exit code 139.

Expected behavior

Tests should pass

Steps to replicate behavior (include URLs)

https://github.com/ZacharyWills/ngen/runs/671741082

Screenshots

[ZacharyWills]

Still getting seg fault

https://github.com/ZacharyWills/ngen/runs/686388461?check_suite_focus=true

[ZacharyWills]

[ZacharyWills]

Tests are now failing to build, and do not make it to the run stage.

https://github.com/ZacharyWills/ngen/runs/691120396?check_suite_focus=true

[hellkite500]

@ZacharyWills @jdmattern-noaa The issue is most likely the test data path is coded relative to the binary, so if the build doesn't make the binary in ngen/build/ or some other single subdir, the file isn't found, which causes a bug in Forcing.h to index a vector out of bounds.

[ZacharyWills]

I changed the path to the root, which works manually but on attempting to get it to run automatedly I run into issues with include/core/catchment/giuh/GIUH.hpp

Not sure why and I'm going to keep dealing with the automation to try and get the tests to work at least. Any location on your caches locally? That would help

[ZacharyWills]

Or post your local step-by-step and I can try it with no temp dir dancing.

[ZacharyWills]

Tests are working macOS but not on Linux, I'll reference this here:#106 (comment)

[ZacharyWills]

Conditions for closing this are simply one pass of tests passing for both platforms, that should suffice for compatibility.

[ZacharyWills]

Passing now: https://github.com/NOAA-OWP/ngen/actions/runs/153129256