Bug fixes for gcc 4.8 make_unique #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build tests fail with this patch: |
|
what is your _GCC_VERSION__ in the test
…On Mon, Jun 29, 2020 at 3:55 PM Nels ***@***.***> wrote:
The build tests fail with this patch:
[ 41%] Building CXX object
src/core/catchment/giuh/CMakeFiles/core_catchment_giuh.dir/GiuhJsonReader.cpp.o
In file included from
/Users/runner/runners/2.263.0/work/ngen/ngen/src/core/catchment/giuh/GiuhJsonReader.cpp:1:
/Users/runner/runners/2.263.0/work/ngen/ngen/include/core/catchment/giuh/GiuhJsonReader.h:31:34:
error: call to 'make_unique' is ambiguous
data_json_tree = std::make_unique(tree);
^~~~~~~~~~~~~~~~~~~~~~~
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#106 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF6KABAUADOENMLHCG4QEPLRZD5UXANCNFSM4OLQYDTA>
.
--
Donald W Johnson
205-347-1467
National Water Center
Tuscaloosa AL
|
|
I pushed a commit that should fix this.
On Mon, Jun 29, 2020 at 4:44 PM Donald Johnson - NOAA Affiliate <
donald.w.johnson@noaa.gov> wrote:
… what is your _GCC_VERSION__ in the test
On Mon, Jun 29, 2020 at 3:55 PM Nels ***@***.***> wrote:
> The build tests fail with this patch:
> [ 41%] Building CXX object
> src/core/catchment/giuh/CMakeFiles/core_catchment_giuh.dir/GiuhJsonReader.cpp.o
> In file included from
> /Users/runner/runners/2.263.0/work/ngen/ngen/src/core/catchment/giuh/GiuhJsonReader.cpp:1:
> /Users/runner/runners/2.263.0/work/ngen/ngen/include/core/catchment/giuh/GiuhJsonReader.h:31:34:
> error: call to 'make_unique' is ambiguous
> data_json_tree = std::make_unique(tree);
> ^~~~~~~~~~~~~~~~~~~~~~~
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#106 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AF6KABAUADOENMLHCG4QEPLRZD5UXANCNFSM4OLQYDTA>
> .
>
--
Donald W Johnson
205-347-1467
National Water Center
Tuscaloosa AL
--
Donald W Johnson
205-347-1467
National Water Center
Tuscaloosa AL
|
hellkite500
approved these changes
Jun 30, 2020
|
Closes #81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues with use of make_unique with gcc 4.8.5 and other Centos 7 issues. Addresses issue #81.
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support