Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install boost from package manager, not source #698

Closed
wants to merge 2 commits into from

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Jan 8, 2024

This'll make the pipelines somewhat less flaky, since they won't rely on an unsupported download source.

It'll also exercise a broader range of versions of Boost than the fixed 1.72 that we were previously testing.

Changes

  • In Github CI jobs that don't build a Docker image, get Boost from apt on Ubuntu and brew on macOS

Testing

  1. Impacts only CI pipelines

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Target Environment support

  • Linux
  • macOS

@PhilMiller
Copy link
Contributor Author

This is mostly a test to see whether we can stop grabbing boost source tarballs and just use the packaged versions available.

This does make us vulnerable to version skew leaving us with incompatibility. I'll see if there's a different Boost mirror that's more cooperative.

@PhilMiller PhilMiller marked this pull request as ready for review January 9, 2024 00:01
@PhilMiller PhilMiller marked this pull request as draft January 10, 2024 15:58
@PhilMiller
Copy link
Contributor Author

Maybe let's not do this - see #700

@PhilMiller PhilMiller closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant