George post ops1 edits #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_post_ops1_edits
twfang
reviewed
Mar 26, 2021
| ! Local | ||
| REAL(prec) :: colat_90km(1:grid % NLP) | ||
| REAL(prec) :: phi_t0 !magnetic longitude,phi[rad] at t0(previous time step) | ||
| REAL(prec) :: theta_t0 !magnetic latitude,theta[rad] at t0 | ||
| REAL(prec) :: coslam, sinim | ||
| INTEGER :: mp, lp, i, lpx, mpx, jth | ||
| REAL(prec), PARAMETER :: rad_to_deg = 57.295779513 | ||
| REAL(prec) :: transport_convection_ratio(1:perp_transport_max_lp, grid % mp_low:grid % mp_high) | ||
| REAL(prec) :: transport_convection_ratio(1:grid % NLP, grid % mp_low:grid % mp_high) |
There was a problem hiding this comment.
@gmillward do we need to change this one?
|
Tzu-Wei
Yes - and it works
Cheers
George.
…On Fri, Mar 26, 2021 at 2:19 AM twfang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/ipelib/IPE_Plasma_Class.F90
<#40 (comment)>:
> ! Local
REAL(prec) :: colat_90km(1:grid % NLP)
REAL(prec) :: phi_t0 !magnetic longitude,phi[rad] at t0(previous time step)
REAL(prec) :: theta_t0 !magnetic latitude,theta[rad] at t0
REAL(prec) :: coslam, sinim
INTEGER :: mp, lp, i, lpx, mpx, jth
REAL(prec), PARAMETER :: rad_to_deg = 57.295779513
- REAL(prec) :: transport_convection_ratio(1:perp_transport_max_lp, grid % mp_low:grid % mp_high)
+ REAL(prec) :: transport_convection_ratio(1:grid % NLP, grid % mp_low:grid % mp_high)
@gmillward <https://github.com/gmillward> do we need to change this one?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF2U5HWNKEG5RFKI4TAUWQTTFQ7SFANCNFSM4Z2F4LAA>
.
--
----------------------------------------------------------------
Dr. George Millward
Cooperative Institute for Research in Environmental Sciences (CIRES)
University of Colorado, Boulder
Visiting scientist at
NOAA Space Weather Prediction Center
Boulder, CO
***@***.***
----------------------------------------------------------------
|
twfang
approved these changes
Mar 27, 2021
akubaryk
approved these changes
Mar 30, 2021
akubaryk
added a commit
that referenced
this pull request
May 6, 2021
George post ops1 edits Conflicts: src/ipelib/IPE_Model_Class.F90 src/ipelib/IPE_Model_Parameters_Class.F90 src/ipelib/IPE_Plasma_Class.F90
chunyen-cu
pushed a commit
to CU-SWQU/IPE
that referenced
this pull request
May 23, 2023
SWPC products
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.