Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone mapping #53

Merged
merged 6 commits into from
Jun 4, 2023
Merged

Tone mapping #53

merged 6 commits into from
Jun 4, 2023

Conversation

NOOBDY
Copy link
Owner

@NOOBDY NOOBDY commented Jun 2, 2023

Map color space from linear -> sRGB -> ACES

@NOOBDY NOOBDY requested a review from x06lan June 2, 2023 03:20
@NOOBDY NOOBDY self-assigned this Jun 2, 2023
vec3 volumeColor;

float density;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pading?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the last element need padding

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be better to prevent forget add padding in the future

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@x06lan x06lan merged commit 809afbe into master Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants