Dask with AOI #574
Dask with AOI #574
Conversation
|
Hello @MarjanAsgari just a quick comment until I can look further into your MR. First of all, thank you for these changes that, I heard, will greatly improve the speed of inference and help with memory management, among other things. Can you please fill in MR description above? Also, it seems your MR includes many log files and test data. Were they added on purpose? If not, could you remove them please? |
environment.yml
Outdated
| - pip: | ||
| - geo-inference>=2.0.7 | ||
| - hydra-colorlog>=1.1.0 | ||
| - hydra-optuna-sweeper>=1.1.0 | ||
| #- git+https://github.com/CosmiQ/solaris.git@0.5.0 |
environment.yml
Outdated
| @@ -9,8 +9,14 @@ dependencies: | |||
| - pytest>=7.1 | |||
| - ruamel_yaml>=0.15 | |||
| - scikit-image>=0.18 | |||
| - dask-image>=2024.5.3 | |||
| - dask>= 2024.6.2 | |||
There was a problem hiding this comment.
can we add a note in the doc for if you have a numpy error it can be cause by numpy 2.0 or somthing
There was a problem hiding this comment.
maybe removing the logs folder for the PR
tests/data/inference/test.csv
Outdated
There was a problem hiding this comment.
Change the path for something else, @mpelchat04 can you check if we have the rights to publicly share this link?
tests/dataset/test_aoi.py
Outdated
There was a problem hiding this comment.
Do we have a test for RGBN?
tests/test_inference_dask.py
Outdated
| # git push origin HEAD:develop | ||
| def inference_with_dask(): | ||
| # GET LIST OF INPUT IMAGES FOR INFERENCE | ||
| list_aois = aois_from_csv( |
There was a problem hiding this comment.
Not sure if we have the rights to share this link
Thank you for submitting your PR and helping us with GDL.
Please read the template below, fill it out as appropriate, and make additional changes to your code as needed.
Please feel free to submit your PR even if it doesn't satisfy all of the requirements below.
If you need assistance or review from a maintainer, add the label Status: Help Needed or Status: Review Needed respectively.
After review, a maintainer will add the label Status: Revision Needed if further work is required for the PR to be merged.
Description
Please include a summary of the change and which issue is resolved (if applicable).
Please also include relevant motivation and context.
List any dependencies that are required for this change.
If it fixes an open issue, please link to the issue here.
Fixes # (issue)
Type of change
What types of changes does your code introduce? Put an
xin all the boxes that apply:How Has This Been Tested?
If the added changes are already cover by tests, skip that section.
Otherwise, please describe tests that you added to the pytest codebase (if applicable).
Screenshots (if applicable):
Checklist:
If you're unsure about any of these, don't hesitate to ask. We're here to help!
If your PR does not fulfill all of the requirements in the checklist above, that's OK! If you need help, @-mention a maintainer and/or add the Status: Help Needed label.