Cost Func Updates #1104
Merged
Cost Func Updates #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add fix to service bid
Massive update documentation for PowerSimulations
jd-lara
reviewed
May 15, 2024
Comment on lines
11
to
12
| ("pwl_incremental_cost_test", 3424.43, ThermalBasicUnitCommitment), | ||
| ("pwl_incremental_fuel_test", 4271.76, ThermalBasicUnitCommitment), |
There was a problem hiding this comment.
@rodrigomha these values should match or the data is wrong.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ("pwl_incremental_cost_test", 3424.43, ThermalBasicUnitCommitment), | ||
| ("pwl_incremental_fuel_test", 4271.76, ThermalBasicUnitCommitment), | ||
| ("non_convex_io_pwl_cost_test", 3047.14, ThermalBasicUnitCommitment), | ||
| ("fixed_market_bid_cost", 3047.14, ThermalBasicUnitCommitment) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| ("fixed_market_bid_cost", 3047.14, ThermalBasicUnitCommitment) | |
| ("fixed_market_bid_cost", 3047.14, ThermalBasicUnitCommitment), |
| "quadratic_fuel_test_ts", | ||
| "pwl_io_fuel_test_ts", | ||
| "pwl_incremental_fuel_test_ts", | ||
| "market_bid_cost" |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| "market_bid_cost" | |
| "market_bid_cost", |
PiecewiseIncrementalCost and PiecewiseAverageCost are modeled the same way, it's just different representations of the data. 
|
rodrigomha
force-pushed
the
rh/cost_funcs_updates_psy4
branch
from
abd9fe8
to
ef6b674
Compare
…SIIP/PowerSimulations.jl into rh/cost_funcs_updates_psy4
…Sienna/PowerSimulations.jl into rh/cost_funcs_updates_psy4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
The systems for testing are defined in NREL-Sienna/PowerSystemsTestData#54 and NREL-Sienna/PowerSystemCaseBuilder.jl#87