Depreciation updates #16
Conversation
…te depreciation assumptions for 2024 atb
* Fix CRP as string bug * rename self._crp to remove ambiguity
| @@ -126,7 +126,7 @@ def __init__( | |||
|
|
|||
There was a problem hiding this comment.
I missed it in a past review, but tcc is missing from the __init__() docstring
| @@ -110,6 +110,7 @@ def __init__( | |||
| @param data_workbook_fname - name of workbook | |||
| @param case - financial case to run: 'Market' or 'R&D' | |||
| @param crp - capital recovery period: 20, 30, or 'TechLife' | |||
| @param tcc - tax credit case: 'ITC only' or 'PV PTC and Battery ITC' Only required for the PV plus battery technology. | |||
There was a problem hiding this comment.
Random question, what happens if someone sets the tcc for LBW or Nuclear?
There was a problem hiding this comment.
It would get passed through to the extractor and set in Excel, but wouldn't change the numbers at all.
There was a problem hiding this comment.
Should none be listed as a valid option given that behavior? Or does "only required for..." convey that?
There was a problem hiding this comment.
I'm fine with that if you are. I don't think the additional complexity of preventing a user from using it incorrectly is worth it minor benefit.
There was a problem hiding this comment.
In tcc : Optional[str] = None, the Optional officially allows the None. To make it a little more type safe you could do: tcc: Optional[ITC_ONLY_CASE| PTC_PLUS_ITC_CASE_PVB] = None
Main changes outside of test data are in tech_processors.py (removing > 2045) and debt_fraction_calc.py (specifying default tax credit case)