-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev to main for 2024 release #19
Conversation
* Add pumped storage hydropower one reservoir processor * Update Nuclear to 2024 CFF calcs, one per tech detail * Update new PTC equations for PV+Battery * Proof of concept debt fraction calcs for PV+Battery * Updates for TaxCreditCase field * correct coal num_tds to account for igcc w/ ccs (#4) * correct coal num_tds to account for igcc w/ ccs * Add coal cases, commit errata data * Automated scraping of different tax credit cases for pv+battery * Add new pumped storage tech processor to example workbooks * Updates for nuclear to start in 2030 * fix classmethod designation for nuclear cff, update test data for mid-flight 2024 data * propigate tax credit case to abstract extractor definition for tests * add additional argument to the mock class to fix tests * clean up class definitions, only mock needs extra argument * Fix minor type hint bugs (#7) * Fix debt fraction calculator to read in tax credit case from file, also handle subset of dates for Nuclear. Some PR comments addressed * docstring to address pr comments * Get tax credit case working in the final flattening steps --------- Co-authored-by: Mike Bannister <mike.bannister@nrel.gov>
* GCC should only be counted once in pv plus battery lcoe, convention is to count it towards PV * update tests given new equation * Minor style and typing changes * Update psh one new res name for mac compatability * minor typing updates --------- Co-authored-by: mbannist <mike.bannister@nrel.gov>
* Update metrics and boolean flags to scrape new capex fields for all battery scales * Update minor blank lines style issue
* Correct default for pv plus battery in debt fraction calculator, update depreciation assumptions for 2024 atb * Update test data for latest tax credit assumptions * Fix CRP as string bug (#15) * Fix CRP as string bug * rename self._crp to remove ambiguity * add missing docstring --------- Co-authored-by: Mike Bannister <mike.bannister@nrel.gov>
* Split offshore wind into fixed and floating * Test and notebook changes for fixed vs floating osw * Correct docstric for better intellisense support
A couple questions/comments about UtilityPVPlusBatteryProc.
|
Looks good to me other than comments above |
Good question. The reason for the custom extractor is to allow for specifying the tax credit case during processing. So we're adequately testing the PTC+ITC case, but not the "ITC only" case. We'd have to do some upgrades to extract_test_data.py and test_lcoe_calculator.py to cover both cases.
Would this also require a change to base_processor.py line 107? Thoughts on handling these in this PR vs making a separate issue? I can see some advantages to merging a little sooner in case users try to use main with the new spreadsheet, but happy to wait to tag the release until this is resolved. |
Your call on the necessity and timing for updating tests. Regarding changes for the custom extractor, see my response comment above on the tech_processors.py file. |
Major changes include: