correct coal num_tds to account for igcc w/ ccs #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebannis
reviewed
Feb 19, 2024
| @@ -231,7 +231,7 @@ class CoalProc(TechProcessor): | |||
| ] | |||
|
|
|||
| sheet_name = 'Coal_FE' | |||
| num_tds = 4 | |||
| num_tds = 5 | |||
There was a problem hiding this comment.
IIRC, num_tds is a bit of a hack as it's defined in the xlsx, but I couldn't figure out an effective way to figure it out w/ python. Something we could look into fixing in the future.
There was a problem hiding this comment.
Thanks! I logged an idea for how to do this here: #5, no rush.
mikebannis
approved these changes
Feb 19, 2024
brtietz
added a commit
that referenced
this pull request
Feb 21, 2024
* Add pumped storage hydropower one reservoir processor * Update Nuclear to 2024 CFF calcs, one per tech detail * Update new PTC equations for PV+Battery * Proof of concept debt fraction calcs for PV+Battery * Updates for TaxCreditCase field * correct coal num_tds to account for igcc w/ ccs (#4) * correct coal num_tds to account for igcc w/ ccs * Add coal cases, commit errata data * Automated scraping of different tax credit cases for pv+battery * Add new pumped storage tech processor to example workbooks * Updates for nuclear to start in 2030 * fix classmethod designation for nuclear cff, update test data for mid-flight 2024 data * propigate tax credit case to abstract extractor definition for tests * add additional argument to the mock class to fix tests * clean up class definitions, only mock needs extra argument * Fix minor type hint bugs (#7) * Fix debt fraction calculator to read in tax credit case from file, also handle subset of dates for Nuclear. Some PR comments addressed * docstring to address pr comments * Get tax credit case working in the final flattening steps --------- Co-authored-by: Mike Bannister <mike.bannister@nrel.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct missing tech detail issue from 2023