Allow higher number of threads than 8 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
changed the title
Added dev warnings too
Myoldmopar
changed the title
|
I pulled out the utf change here since that was not being covered by unit tests and was the reason this branch was failing. I'll pull in the CPU count here if this passes now. |
|
Coveralls seems to be really confused. This should be covering the entire codebase. Looking at the source list it seems to indicate zero lines were missed. Yet it won't collect the results between both Py2 and Py3 builds to get to 100%. Not sure why. Anyway, merging this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #33: use
os.cpu_count()to set the high range of number of threads in main_window.pyFix #32: Handle files that could have non-UTF-8 encoding (at least: AirflowNetwork_MultiAirLoops, AirflowNetwork_PressureControl)
@Myoldmopar