Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
CI Updates
This update makes CI builds consistent with the install instructions for developers. It also allows us to set up Mac builds, which are disabled for now (see #154).
Structural Changes
This is essentially a small chunk of the work happening in
dev/refactor
. It creates a new folder structure that has the following high-level structure:This is part of a proposed strategy to make small, manageable PRs into
develop
(now branch-protected) based on the refactor work, which will allow us to stay up-to-date withmaster
, keep the test suite stable, and review the software design in reasonable chunks.dev/refactor
in its current state has diverged greatly frommaster
(see compare, which is so large that GitHub can't display the file changes), and even if we are able to make the CI stable again (current builds fail for an unknown reason), the PR tomaster
will be so large that it will be very difficult to review.The proposed process is iterative:
dev/refactor
develop
For example, the PR after this would pull the HOPP interface changes and yaml input structure, and the PR after that would pull new hydrogen features introduced in Green Steel, etc. in smaller chunks