Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VASP from Running on Vermilion #501

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

yandthj
Copy link
Collaborator

@yandthj yandthj commented Sep 20, 2023

No description provided.

Copy link
Collaborator

@tayloraubry tayloraubry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Apart from this PR I think this page could probably be cleaned up further.

It is very long and detailed. If all of this information is necessary it could be arranged more in drop downs so that essential information is immediately visible and then users can seek drop down sections for more detail on building.

Additionally, some of the section headers could be improved
e.g. "Building hello world first" to "Example: building a simple program"

And some of the headers do not appear to be at the correct level
e.g. shouldn't "full-procedure-screen-dump" be a subheader under "building hello world first"

docs/Documentation/Systems/Vermilion/modules.md Outdated Show resolved Hide resolved
docs/Documentation/Systems/Vermilion/modules.md Outdated Show resolved Hide resolved
docs/Documentation/Systems/Vermilion/modules.md Outdated Show resolved Hide resolved
@yandthj
Copy link
Collaborator Author

yandthj commented Oct 2, 2023

Thanks for the review! John is working on improving the Running page as well. Once he is finished we can see if we should have an additional issue for formatting/clean up.

@yandthj yandthj merged commit 4c3c848 into NREL:gh-pages Oct 13, 2023
@yandthj yandthj deleted the vermilion-remove-vasp branch October 13, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants