-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove VASP from Running on Vermilion #501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Apart from this PR I think this page could probably be cleaned up further.
It is very long and detailed. If all of this information is necessary it could be arranged more in drop downs so that essential information is immediately visible and then users can seek drop down sections for more detail on building.
Additionally, some of the section headers could be improved
e.g. "Building hello world first" to "Example: building a simple program"
And some of the headers do not appear to be at the correct level
e.g. shouldn't "full-procedure-screen-dump" be a subheader under "building hello world first"
Thanks for the review! John is working on improving the Running page as well. Once he is finished we can see if we should have an additional issue for formatting/clean up. |
No description provided.