Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of Amr-wind and Openfoam build instructions #608

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Addition of Amr-wind and Openfoam build instructions #608

merged 6 commits into from
Apr 23, 2024

Conversation

arswalid
Copy link
Collaborator

@arswalid arswalid commented Apr 9, 2024 •
edited
Loading

mkdocs needs to be edited to add openfoam page

@arswalid arswalid changed the title Addition of Amr-wind build instructions Addition of Amr-wind and Openfoam build instructions Apr 9, 2024
This was referenced Apr 9, 2024
Open
Open
yandthj
yandthj requested changes Apr 10, 2024
View reviewed changes
docs/Friendly_User/Applications/amrwind.md Outdated Show resolved Hide resolved
docs/Friendly_User/Applications/amrwind.md Outdated Show resolved Hide resolved
docs/Friendly_User/Applications/amrwind.md Outdated Show resolved Hide resolved
docs/Friendly_User/Applications/amrwind.md Outdated Show resolved Hide resolved
docs/Friendly_User/Applications/amrwind.md Outdated Show resolved Hide resolved
docs/Friendly_User/Applications/openfoam.md Outdated Show resolved Hide resolved
docs/Friendly_User/Applications/openfoam.md Outdated Show resolved Hide resolved
docs/Friendly_User/Applications/openfoam.md Outdated Show resolved Hide resolved
docs/Friendly_User/Applications/openfoam.md Outdated Show resolved Hide resolved
docs/Friendly_User/Applications/openfoam.md Outdated Show resolved Hide resolved
arswalid
arswalid commented Apr 17, 2024
View reviewed changes
Copy link
Collaborator Author

@arswalid arswalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments were addressed

@yandthj yandthj marked this pull request as ready for review April 17, 2024 16:04
yandthj
yandthj reviewed Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@yandthj yandthj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should OpenFoam be added to the GPU Friendly Users, or the main applications section? It needs to be added to the nav section in the mkdocs.yml file in either case

@arswalid
Copy link
Collaborator Author

Hi Haley,
I was thinking GPU Friendly Users page

@yandthj yandthj merged commit f065fb1 into NREL:gh-pages Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yandthj yandthj yandthj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arswalid @yandthj