-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FoundationWall insulation flexibility #355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set_fndwall_insulation
e1a5ca5 Merge branch 'kiva_offset_fndwall_insulation' of https://github.com/NREL/OpenStudio-HPXML into kiva_offset_fndwall_insulation 826fec8 Update. a18fd7f First pass on updating HVAC sizing. a3b3d9b Merge branch 'kiva_offset_fndwall_insulation' of https://github.com/NREL/OpenStudio-HPXML into kiva_offset_fndwall_insulation 78ad357 cleanups. 72a3f4e Remove add/get insulation helper methods from hpxml.rb. They are more trouble than they're worth given all the unique nuances of each element. 23c73cb change new test file exterior height b34e222 unconditioned basement configuration revert from 1 offset to 0 offset dc40966 Revert a test for double specifying foundationwall insulation. Change EPvalidator. d0abc89 Always requires one exterior layer and one interior layer. adf5845 revert test bade32d Merge branch 'kiva_offset_fndwall_insulation' of https://github.com/NREL/OpenStudio-HPXML into kiva_offset_fndwall_insulation 526f038 revert extension names e3a2414 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into kiva_offset_fndwall_insulation 857c284 Merge pull request #255 from NREL/code_cleanup ef453b3 unit fix and minor changes ac57f82 Oops, wrong name 4ea602f rake a few test files to only insulation below grade walls 3b0f698 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into kiva_offset_fndwall_insulation d434231 Once customblock functions well, rerake base to be 1 ft offset 1b08c9d Changed assembly-r check to interact with custom block inputs 7c925c2 Oops 0f92c59 redo comparison: changed kiva inputs to always use custom blocks. Added drywall thickness for x position. 63847b4 Add interior insulation test files f5a1b68 bug-fix 4c10c14 Oops, revert test file ae264b0 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into kiva_offset_fndwall_insulation 7f2864a Implemented interior insulation-untested. Changed extension name. 7d60b7b use layer extension to describe distance to top/bottom fdac374 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into kiva_offset_fndwall_insulation ea8d6a2 Revert base to be 0 offset for CI comparison 80e6041 bug-fix for assembly-r scenario c4ff01d fix bugs in merging master fda20dc fix bugs to run rake successfully b7521b8 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into kiva_offset_fndwall_insulation 82ca454 First pass at handling foundation wall insulation offset. Completely untested. git-subtree-dir: measures/HPXMLtoOpenStudio git-subtree-split: e1a5ca5
…set_fndwall_insulation
…set_fndwall_insulation
…set_fndwall_insulation
This was referenced Jan 10, 2020
shorowit
added a commit
that referenced
this pull request
May 11, 2020
58373423d Merge pull request #310 from NREL/outside-boundary-conditions c73454270 bugfix, collapse other housing unit schedules, fix hardcoding living space name e4af0c4cd remove base-misc-locations-other.xml, fixed rh/hr issue 44322a232 Merge branch 'outside-boundary-conditions' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions d9d8ba28a some small issues ce8e83bc1 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions ec4db5bd6 Revert the part of the HPWH ducting program that was related to internal gains. c195a7e6f Merge pull request #382 from NREL/hpxml_datatype_conversions e2a371e3d Relax test tolerance. 57649b906 Also handle 1/0 (integer) conversion to boolean. e1d6d1e50 Update documentation. [ci skip] 9be79f874 other housing unit surface changed to use sch 199846419 Merge branch 'outside-boundary-conditions' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions 532da3817 minor changes b98e91185 Improve datatype conversions used by HPXML class. In particular, prevents automatically converting non-integer values to integers. ec6be234d Oops. Bugfix. 67c580886 Remove unnecessary @mf_temp_sch_map variable and other minor code cleanup. Also removed some HPWH code (ducting, etc.) that isn't being used. Should be functionally the same. 8af5cae9a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions 2f21345eb Remove old test files. bef9fb811 Merge pull request #355 from NREL/enclosure_error_checking e36a773e4 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into enclosure_error_checking b51b7e632 Compromise to allow for ASHRAE 140 while still generally requiring lighting. dc80c7835 Merge pull request #381 from NREL/lighting-cleanup cdfc22de4 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into enclosure_error_checking e12e1f335 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions bf90de843 minor changes 24339bdcd remove window location error checking b1d213959 accommodate new report arg ededf86d2 merge conflict bugfix 9aeb4d5d4 update_measures 9af8bb38f Merge branch 'os_v3' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions b9d8d01d3 combined coefficient assumption d92f4c82e update_measures 6b9e30881 Merge branch 'os_v3' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions 0f7c405cc report test accommodation column name 53ee01125 v3.0 othersidecoefficient schedule d18a6cab1 Merge branch 'os_v3' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions ee9ce6231 Adds tests. 9140754df First pass on adding better space type-specific error checking of surfaces. ac46e80b5 revert base* e0c2b70cc changes to corresponding tests ceff63ec1 some changes to test files 6fc3c83c7 test base-miscs-locations-other.xml added d89da3018 new test files for mf spaces b2c540d21 bugfix ad6e1b87c duct bugfixes and cleanup(somehow) c54595ab7 changes to first batch of suggestions f67623496 some changes after merging master 6bb69608a rake 5f54ffdff Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions 698592b83 added a "Surface" outside boundary condition subsurface to verify previous implementation bug was fixed e20411be4 ran update_measures 10ed69e8b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions b53264d9d fix a bug in assigning outside boundary condition to subsurfaces 30c5e9d1f default dishwasher and cooking range locations c36cc8d04 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions 2ea13f695 invalid d22772623 merge 1ceebc35a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions 0ab037a62 bugfix, new warning resolved f0de0eefc one more fix... 7a3e191bf bugfix f6a775d64 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions 450b6d3a5 cleanup and minor changes 9cddaa86d revert test bbae3f637 cleanup be90fb9dd dishwasher test bugfix 51d2f8f7d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions 6df50bf38 fixed some merge and ci failure issues 0416fb61c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions b73a20457 surface hvac_sizing and appliance progresses 5f4977166 current appliance location init 96560fb88 Unnecessary line a175069a0 duct location 0e480802d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions 178ba2550 one remaining issue of merging new hpxml class ef81d7033 rubocop beb4cac4d conflicts and issues fd13012cc pulled in masters 81d8a85cf oops, removed the wrong line 81d1add00 remove diagnostic puts e6e5494fe waterheater sharing obc schedule with surfaces a5c4f1c61 progress on water heater location bfff94d5e ran rake + conflicts resolved ba6de136b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions fff4145aa Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions 7ac14a3bc subsurface on foundation wall 09e957c60 hpxml schema changes, new enumerations 9cd567460 addressed subsurfaces 400dbd0c2 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into outside-boundary-conditions fbf4cb261 fixme comment c962c5f00 MES program to read conditioned zone temperature a3eee53b2 something left from previous commit, added report tests. 538a7581c new space type test files combined. b3016f3f2 remove diagnostic print 28dbe99a3 Other side coefficient, 0 convection first for debugging git-subtree-dir: hpxml-measures git-subtree-split: 58373423d5022ace89d39aa9de0bbe576d687c5c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows:
For walls described with an insulation layer, both interior and exterior layers now must be described. For example, an uninsulated wall that used to be described as
is now described as
For walls described with an assembly R-value, there is no change required. A wall can continue to be described like so: