Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANSI 301 2022: Reference WH location #713

Merged
merged 20 commits into from
Apr 23, 2024
Merged

ANSI 301 2022: Reference WH location #713

merged 20 commits into from
Apr 23, 2024

Conversation

jmaguire1
Copy link
Collaborator

@jmaguire1 jmaguire1 commented Jan 29, 2024 •
edited by shorowit
Loading

Pull Request Description

Update the reference home water heater installation location for 2022 rules. Use the default installation location rather than same location as the rated building.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • OS-HPXML git subtree has been pulled
  • 301/ES rulesets and unit tests have been updated
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Workflow tests have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI

@jmaguire1
Update rule for reference WH to use default installation location log…
05a8120 
…ic if 2022, rather than the same location as the rated WH
@jmaguire1 jmaguire1 marked this pull request as draft January 29, 2024 21:16
@jmaguire1 jmaguire1 changed the title Reference WH location ANSI/RESNET 2022: Reference WH location Jan 29, 2024
@jmaguire1 jmaguire1 changed the title ANSI/RESNET 2022: Reference WH location ANSI 301 2022: Reference WH location Jan 29, 2024
Base automatically changed from ansi_301_2022 to latest-os-hpxml February 8, 2024 01:46
jmaguire1 and others added 3 commits February 19, 2024 13:44
@jmaguire1
Fix some failing tests. Not 100% done yet though
1ec54e6
@shorowit
Merge branch 'latest-os-hpxml' of https://github.com/NREL/OpenStudio-ERI
8d11c31 
 into ansi_301_2022_ref_wh

# Conflicts:
#	workflow/tests/base_results/real_homes.csv
#	workflow/tests/base_results/sample_files1.csv
#	workflow/tests/base_results/sample_files2.csv
Latest results.
bf0adde
jmaguire1 and others added 9 commits April 1, 2024 13:05
@jmaguire1
Implement Scott's suggestions (use 2022 instead of 2019ABCD, set loca…
ed89fcf 
…tion to nil so it's set later)
@jmaguire1
Merge branch 'latest-os-hpxml' of https://github.com/NREL/OpenStudio-ERI
3fe2a5e 
 into ansi_301_2022_ref_wh
@jmaguire1
hmmm, "nil" for the default location was causing issues, so I'm going…
149e1f8 
… to revert to getting the default location here instead of passing nil and assigning later.
@jmaguire1
Merge branch 'latest-os-hpxml' of https://github.com/NREL/OpenStudio-ERI
4ba2823 
 into ansi_301_2022_ref_wh
Latest results.
f41a353
@jmaguire1
Merge branch 'latest-os-hpxml' of https://github.com/NREL/OpenStudio-ERI
dbfe297 
 into ansi_301_2022_ref_wh
Latest results.
47cbe75
@jmaguire1
Fix some failing tests.
00cd28c 
Now that we gave conditioned basements priority over the main living space in certain CZs, some runs where WH location defaults end up in conditioned basements, not the living space.
@jmaguire1
Merge branch 'ansi_301_2022_ref_wh' of https://github.com/NREL/OpenSt…
2836a73 
…udio-ERI into ansi_301_2022_ref_wh
@jmaguire1 jmaguire1 marked this pull request as ready for review April 23, 2024 14:50
@shorowit shorowit merged commit 75959e8 into latest-os-hpxml Apr 23, 2024
0 of 6 checks passed
@shorowit shorowit deleted the ansi_301_2022_ref_wh branch April 23, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit shorowit approved these changes

Assignees

@jmaguire1 jmaguire1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmaguire1 @shorowit