Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM:MixedAir creation for CoilSystemCoolingWaterHeatExchangerAssisted does not work with FanSystemModel #4896

Closed
eringold opened this issue May 26, 2023 · 0 comments · Fixed by #4899

Comments

@eringold
Copy link
Contributor

eringold commented May 26, 2023

Issue overview

Attn: @jmarrec

After working around #4895, I get severe errors due to missing SPM on the sensor node referenced by ControllerWaterCoil. This happens because I'm creating and AirLoop with a FanSystemModel, but the FT code that creates the SPM:MixedAir is only looking for FanVariableVolume or FanConstantVolumes:

for (auto it = supplyComponents.begin(); it != supplyComponents.end(); ++it) {
if (boost::optional<FanVariableVolume> variableFan = it->optionalCast<FanVariableVolume>()) {
fans.insert(fans.begin(), *variableFan);
} else if (boost::optional<FanConstantVolume> constantFan = it->optionalCast<FanConstantVolume>()) {
fans.insert(fans.begin(), *constantFan);
}
}

Possible Solution

Look for other fan types.

Context

😵‍💫

@eringold eringold added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label May 26, 2023
@jmarrec jmarrec added severity - Normal Bug component - HVAC component - IDF Translation and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels May 30, 2023
@jmarrec jmarrec self-assigned this May 30, 2023
jmarrec added a commit that referenced this issue May 30, 2023
…terHeatExchangerAssisted does not work with FanSystemModel
jmarrec added a commit that referenced this issue May 30, 2023
…terHeatExchangerAssisted does not work with FanSystemModel
jmarrec added a commit that referenced this issue Jun 29, 2023
Fix #4896 - SPM:MixedAir creation for CoilSystemCoolingWaterHeatExchangerAssisted does not work with FanSystemModel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment