-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add surface method for SurfacePropertyExposedFoundationPerimeter
#4892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest deprecating the surfaceName()
method. All other changes LGTM.
@@ -70,6 +70,8 @@ namespace model { | |||
|
|||
std::string surfaceName() const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want OS_DEPRECATED
for that one. Remove from Impl, and do surface().nameString()
in the deprecated method
CI Results for 6c84b6c:
|
Pull request overview
SurfacePropertyExposedFoundationPerimeter
has surfaceName method instead of surface #4890Pull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.