Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4990 python run tests #5008

Merged
merged 3 commits into from Oct 30, 2023
Merged

4990 python run tests #5008

merged 3 commits into from Oct 30, 2023

Conversation

kbenne
Copy link
Contributor

@kbenne kbenne commented Oct 30, 2023

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

jmarrec and others added 3 commits October 30, 2023 16:28
The packages contained in python/requirements.txt will now be included
in the OpenStudio distribution by default.

ref #4992
Now the command will grep for all ruby based measure tests in the
specified directory. Previously the implementation was searching for a
single Measure in an attempt to determine Ruby/Python.

Future changes will open an option to control Ruby/Python
@kbenne kbenne self-assigned this Oct 30, 2023
@kbenne kbenne merged commit 3023b7a into develop Oct 30, 2023
2 checks passed
@kbenne kbenne deleted the 4990-python-run-tests branch October 30, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants