Fixing run workflow with outdated measures #5015
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Check arity for ReportingMEasure::arguments: model arg was added later at 3.0.0
We should make these methods be in the Ruby/Python engine probably....
The reg tests still throw, but later at
OpenStudio/src/workflow/ApplyMeasure.cpp
Line 190 in c0cbe73
Fix C++ CLI: Run options in OSW are being ignored #5017
Fix If a reporting measure throws an error (runner.registerError("ERROR TEST"); return false), openstudio doesn't seem to gracefully handle it: #5020
Pull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.