Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade TMY warning to info message #5093

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Downgrade TMY warning to info message #5093

merged 1 commit into from
Feb 23, 2024

Conversation

shorowit
Copy link
Contributor

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@shorowit shorowit added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. component - logs and warnings labels Feb 21, 2024
@shorowit shorowit added this to the OpenStudio SDK 3.8.0 milestone Feb 21, 2024
@shorowit shorowit self-assigned this Feb 21, 2024
@jmarrec
Copy link
Collaborator

jmarrec commented Feb 21, 2024

I guess I forgot to push/open a PR. I did this, and I downgraded it to debug since it's so common. Not sure which one you'd like better, info or debug

Copy link
Collaborator

@jmarrec jmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@jmarrec jmarrec merged commit b25e616 into develop Feb 23, 2024
4 of 6 checks passed
@jmarrec jmarrec deleted the tmy_warning branch February 23, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - logs and warnings Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce TMY warnings
4 participants