-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5103 - ElectricEquipmentITEAirCooled / ElectricEquipmentITEAirCooledDefinition - align objects with other SpaceLoads #5105
Conversation
…r Zone Floor Area" and replace with "Watts per Space Floor Area"
@@ -4140,7 +4140,7 @@ OS:ElectricEquipment:ITE:AirCooled:Definition, | |||
\units W | |||
\ip-units W | |||
\minimum 0 | |||
N2 , \field Watts per Zone Floor Area | |||
N2 , \field Watts per Space Floor Area |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDD change
/** Returns the designLevel if possible based on the underlying data of electricEquipmentITEAirCooledDefinition(). */ | ||
boost::optional<double> powerPerFloorArea() const; | ||
OS_DEPRECATED(3, 8, 0) boost::optional<double> wattsperZoneFloorArea() const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely the case for all SpaceLoadInstance objects
/** Returns the designLevel if possible based on the underlying data of electricEquipmentITEAirCooledDefinition(). */ | ||
boost::optional<double> designLevel() const; | ||
OS_DEPRECATED(3, 8, 0) boost::optional<double> wattsperUnit() const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That one is debatable I suppose. Lights for eg also doesn't use designLevel
but lightingLevel
. But I think Lights is wrong, and all SpaceLoadInstance should follow this convention.
boost::optional<double> wattsperSpaceFloorArea() const; | ||
OS_DEPRECATED(3, 8, 0) boost::optional<double> wattsperZoneFloorArea() const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is a sure thing. Per Zone Floor Area makes no sense.
boost::optional<double> designLevel() const; | ||
OS_DEPRECATED(3, 8, 0) boost::optional<double> wattsperUnit() const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also debatable I suppose, but I stand by it.
/** Returns the watts/m^2 represented by this definition, assuming floorArea (m^2) */ | ||
double getPowerPerFloorArea(double floorArea) const; | ||
OS_DEPRECATED(3, 8, 0) double getWattsperZoneFloorArea(double floorArea) const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
/** Returns the design level represented by this definition, assuming floorArea (m^2). */ | ||
double getDesignLevel(double floorArea) const; | ||
OS_DEPRECATED(3, 8, 0) double getWattsperUnit(double floorArea) const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debatable but I prefer it!
For a list of deprecated and removed methods, please refer to [deprecated_methods.csv](../../ruby/deprecated_methods.csv) | ||
|
||
* [#TDB]() - Update to EnergyPlus 24.1.0 | ||
|
||
* [#5099](https://github.com/NREL/OpenStudio/pull/5099) - HeatExchangerAirToAirSensibleAndLatent changes for effectiveness | ||
* To conform to E+ 24.1.0, where "Sensible/Latent Effectiveness at 75% Heating/Cooling" numeric fields have been replaced with a curve, the numeric getters / setters are now deprecated in favor of the new curves getters / setters: `sensibleEffectivenessofHeatingAirFlowCurve`, `latentEffectivenessofHeatingAirFlowCurve`, `sensibleEffectivenessofCoolingAirFlowCurve`, `latentEffectivenessofCoolingAirFlowCurve` | ||
* The constructor will no longer assign an effectiveness at 75% and assume a constant effectiveness. A helper method `bool assignHistoricalEffectivenessCurves()` is provided to create and assign 4 `TableLookup`s that will match the pre E+ 24.1.0 defaults for Sensible/Latent Effectiveness at 75% Heating/Cooling airflow | ||
* [#5105](https://github.com/NREL/OpenStudio/pull/5105) - ElectricEquipmentITEAirCooled / ElectricEquipmentITEAirCooledDefinition - align objects with other SpaceLoads | ||
* A number of methods have been renamed (and the old ones deprecated) to conform to the API for other `SpaceLoadInstance` / `SpaceLoadDefinition` objects | ||
* Mostly `getWattsperUnit` is changed to `getDesignLevel` and `getWattsperZoneFloorArea` is changed to `getPowerPerFloorArea` | ||
* Refer to [deprecated_methods.csv](../../ruby/deprecated_methods.csv) for the complete list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Release notes, including for v24.1.0-IOFreeze: HeatExchangerAirToAirSensibleAndLatent #5099
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the deprecated_methods.csv for this PR + any missing ones before
CI Results for 680da5d:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment, otherwise LGTM.
|
||
boost::optional<double> wattsperZoneFloorArea() const; | ||
/** Returns the designLevel if possible based on the underlying data of electricEquipmentITEAirCooledDefinition(). */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Returns the powerPerFloorArea if possible ..."?
Pull request overview
Pull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.