Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to E+ v24.1.0-RC3 #5130

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Update to E+ v24.1.0-RC3 #5130

merged 1 commit into from
Mar 27, 2024

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Mar 27, 2024

Pull request overview

Note that the macOS 10.15 x64 was removed in this release so I'm using the oldest available (11.6).

The i386 windows also is not available at the moment, was disabled on GHA via NREL/EnergyPlus@cdedd14 (I think @Myoldmopar built it manually for 23.2.0?)

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

Note that the macOS 10.15 x64 was removed in this release.
The i386 windows also is not available at the moment
@jmarrec jmarrec added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Mar 27, 2024
@jmarrec jmarrec self-assigned this Mar 27, 2024
@jmarrec
Copy link
Collaborator Author

jmarrec commented Mar 27, 2024

Ok, CI finished on it, let's merge it so we can trigger a develop build asap.

@jmarrec jmarrec merged commit c6fe854 into develop Mar 27, 2024
4 of 6 checks passed
@jmarrec jmarrec deleted the v24.1.0-RC3 branch March 27, 2024 14:41
@joseph-robertson joseph-robertson added this to the OpenStudio SDK 3.8.0 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants