Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5192 - Fix runner.getPastStepValuesForMeasure can cause segfault #5194

Merged
merged 4 commits into from
May 15, 2024
Merged

#5192 - Fix runner.getPastStepValuesForMeasure can cause segfault #5194

merged 4 commits into from
May 15, 2024

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented May 13, 2024 •
edited

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added component - CLI Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. component - Ruby bindings labels May 13, 2024
@jmarrec jmarrec self-assigned this May 13, 2024
@DavidGoldwasser DavidGoldwasser mentioned this pull request May 14, 2024
Open
60 tasks
@jmarrec
```
4cfd581 
The following tests FAILED:
	3705 - RubyTest-SwigJson_Test-swig_json_special_chars (Failed)
	3870 - CLITest-SwigJson_Test-swig_json_special_chars (Failed)
```
@jmarrec
not working yet...
d89233a
@jmarrec
Forward declaration works
f36e7e5
@jmarrec
Solve it via fragments
fb533a2
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented May 15, 2024 •
edited

CI Results for fb533a2:

@kbenne kbenne merged commit d8d56bc into develop May 15, 2024
4 of 6 checks passed
@kbenne kbenne deleted the 5192_hash_encoding branch May 15, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph-robertson joseph-robertson Awaiting requested review from joseph-robertson

Assignees

@jmarrec jmarrec

Labels
component - CLI component - Ruby bindings Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runner.getPastStepValuesForMeasure can cause segfault
3 participants
@jmarrec @ci-commercialbuildings @kbenne