Kempe gap calc #87
Merged
Kempe gap calc #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a metadata variable name to a proper "wind_height" and "module_temperature"
Fixed some of the output statements to be clearer. Changed the poa_min default to b 400 W/m2 as opposed to 100 W/m2. Lots of work to streamline the calculator for Xeff. Removed superfluous passing of variables. Put in better default control over tilt to use latitude if none is provided. Also put in checks to make sure the tilt and azimuth are provided in the *.csv file.
Fixed a problem with the generic *.csv importer I wrote. There was a problem with the index timezone (thanks Silvana)., and a problem with importing variables as strings instead of floats in the meta data.
Fixed some of the textual output. Simplified and streamlined the calculations for Xeff. Removed some lines to import weather data directly using PVlib because this would cause variable formatting issues. It now properly uses weather.read.
I added in another way to fix timezone. This was causing a problem on a pytest with LETID.
The meta data did not have the proper name for the time zone. So I added in the maping function.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
===========================================
+ Coverage 47.72% 62.54% +14.82%
===========================================
Files 28 29 +1
Lines 1800 2096 +296
===========================================
+ Hits 859 1311 +452
+ Misses 941 785 -156 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the Xeff calculation to work and fixed a few other issues. However, I was working on the standoff Jupyter notebook which probably needs to replace the 63126 tool.