-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON code generation for hybrids #1515
Comments
Need support for SSC_DATA_ARRAY and SSC_TABLE types for all supported hybrid generation.
Issue 1515 has been updated to JSON generation only for hybrids and the other languages have been moved to Patch 2 in Issue #1717 per the 2/27/2024 SAM meeting |
@sjanzou The hybrid Pvsamv1 JSON generation has UI variables, but the original Pvsamv1 JSON generation doesn't. Are the UI variables meant to be part of "JSON for inputs"? |
Restored SAM_1515 branch of SAM and limited the "JSON for inputs" to compute module inputs only... the ssc test no longer runs for the patch branch and SAM_1515 branches of ssc since the additional inputs for costs and o and m are not included. Hopefully, this will work with the pysam_hybrids branch of ssc. Please test changes to codegenrator.cpp from SAM branch SAM_1515 with your ssc branch and let me know. Thanks! |
Merge branch 'patch' into SAM_1515, fix reopened issue #1515
The code generation for hybrids needs to be updated.
For example, the JSON for inputs for the Generic PVWatts Wind Fuel Cell Battery Single Owner produces
The generated inputs should be able to be processed by cmod_hybrids and be structured like the defaults
The text was updated successfully, but these errors were encountered: