Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON code generation for hybrids #1515

Closed
sjanzou opened this issue Oct 23, 2023 · 3 comments · Fixed by #1718 or #1765
Closed

JSON code generation for hybrids #1515

sjanzou opened this issue Oct 23, 2023 · 3 comments · Fixed by #1718 or #1765
Assignees
Labels

Comments

@sjanzou
Copy link
Collaborator

sjanzou commented Oct 23, 2023

The code generation for hybrids needs to be updated.

For example, the JSON for inputs for the Generic PVWatts Wind Fuel Cell Battery Single Owner produces
image

The generated inputs should be able to be processed by cmod_hybrids and be structured like the defaults
image

@sjanzou sjanzou added the bug label Oct 23, 2023
@sjanzou sjanzou added this to the SAM Fall 2023 Release milestone Oct 23, 2023
@sjanzou sjanzou self-assigned this Oct 23, 2023
sjanzou added a commit that referenced this issue Nov 7, 2023
Need support for SSC_DATA_ARRAY and SSC_TABLE types for all supported hybrid generation.
@sjanzou sjanzou changed the title Code generation for hybrids JSON code generation for hybrids Feb 28, 2024
@sjanzou
Copy link
Collaborator Author

sjanzou commented Feb 28, 2024

Issue 1515 has been updated to JSON generation only for hybrids and the other languages have been moved to Patch 2 in Issue #1717 per the 2/27/2024 SAM meeting

@dguittet
Copy link
Collaborator

@sjanzou The hybrid Pvsamv1 JSON generation has UI variables, but the original Pvsamv1 JSON generation doesn't. Are the UI variables meant to be part of "JSON for inputs"?

@dguittet dguittet reopened this Feb 29, 2024
@sjanzou
Copy link
Collaborator Author

sjanzou commented Mar 1, 2024

@sjanzou The hybrid Pvsamv1 JSON generation has UI variables, but the original Pvsamv1 JSON generation doesn't. Are the UI variables meant to be part of "JSON for inputs"?

Restored SAM_1515 branch of SAM and limited the "JSON for inputs" to compute module inputs only... the ssc test no longer runs for the patch branch and SAM_1515 branches of ssc since the additional inputs for costs and o and m are not included. Hopefully, this will work with the pysam_hybrids branch of ssc.

Please test changes to codegenrator.cpp from SAM branch SAM_1515 with your ssc branch and let me know. Thanks!

@sjanzou sjanzou linked a pull request Apr 24, 2024 that will close this issue
sjanzou added a commit that referenced this issue Apr 24, 2024
Merge branch 'patch' into SAM_1515, fix reopened issue #1515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment