Updates python to 3.12 #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps all packages/deps Removes pylama (no longer maintained)
😢 do we want to add in the things pylama used to package? or a different code auditor? |
|
|
Looks like pylama has been ghosted. There's even an outstanding PR that fixes the python 3.12 issues here, but no love from the maintainer. As for pylama replacement, I don't fully understand all the things it did, so I'm ill equipped to recommend a replacement. Do you have preferences? I dig into this in the coming days |
haneslinger
approved these changes
Aug 28, 2024
Comment on lines
-12
to
-17
| - repo: https://github.com/gvanderest/pylama-pre-commit | ||
| rev: 0.1.2 | ||
| hooks: | ||
| - id: pylama | ||
| additional_dependencies: | ||
| - pyflakes==2.4.0 |
There was a problem hiding this comment.
pulled the pylama pre-commit due to the pylama errors
| @@ -9,32 +9,32 @@ authors = ["Your Name <you@example.com>"] | |||
| repository = "https://github.com/NREL/Wattile" | |||
haneslinger
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Updates python to 3.12 Bumps all packages/deps Removes pylama (no longer maintained) * Pins numpy at v1 major release * Uses tilde versioning over caret (easier to reason about)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps all packages/deps
Removes pylama (no longer maintained)