Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate s3 #121

Closed
wants to merge 2 commits into from
Closed

Validate s3 #121

wants to merge 2 commits into from

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Nov 23, 2019

Partially addresses #53 .

Pull Request Description

  • An option is added in the project yaml file to specify the s3 upload folder name.
  • Validates that there are no existing data in the s3 upload location.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on CircleCI build -> Artifacts)
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)

@rajeee rajeee requested a review from nmerket November 23, 2019 00:52
@rajeee rajeee self-assigned this Nov 23, 2019
@nmerket
Copy link
Member

nmerket commented May 21, 2020

@rajee This has been here for a long while and looks like it could take some work to resolve conflicts. Do you still want this to go in?

@rajeee
Copy link
Contributor Author

rajeee commented May 21, 2020

@rajee This has been here for a long while and looks like it could take some work to resolve conflicts. Do you still want this to go in?

@nmerket Yeah, I think I was waiting on the yaml file refactoring before merging this. I guess, that refactoring is yet to happen? I think things are still duplicated between postprocessing and aws spec.

@nmerket
Copy link
Member

nmerket commented May 22, 2020

Sounds good. I'll leave it alone until then.

@nmerket nmerket closed this Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants