-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to OS v3.5.1 #337
Update to OS v3.5.1 #337
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6942c8b |
@@ -317,6 +318,7 @@ def create_osw(self, sim_id, building_id, upgrade_idx): | |||
'include_timeseries_airflows': False, | |||
'include_timeseries_weather': False, | |||
'timeseries_timestamp_convention': 'end', | |||
'timeseries_num_decimal_places': 3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this, otherwise we break backward compatibility. On the other hand if this was a required argument, then we may need to break backward compatibility (i.e., old versions of ResStock won't work with newer version of the workflow generator).
Pull Request Description
Updates for support of latest OS-HPXML.
Closes #340.
Checklist
Not all may apply
minimum_coverage
in.github/workflows/ci.yml
as necessary.