-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize model inputs and parameters #81
Comments
The mass input file would be melted to look like:
Complete input file is here: I'm inclined not to include the total component mass in this input file, as it's easy to do that calculation programmatically. Edited 11/3 to include technology column |
@rjhanes I agree about excluding the total component mass. This updated file format looks good to me. |
@rjhanes one quick note that I think we need to add a technology column as well. I know we're only currently considering one technology but I think we want to be able to specify others. Current technology label: "land-based wind" |
See related issue https://github.nrel.gov/akey/celavi-data/issues/42 in the data repo Sub-tasks:
Some of the preprocessing code, like the TurbineLocations class in the data manager and the portion of compute_locations that works with the raw US WTDB, can't really be generalized because that input data will look different for different technologies. We'll need to call that out in the manuscript & documentation. We may want to think a little bit more about the parameter naming convention in the config. Maybe something like: pathway names pathway parameters |
Current config file format to match with commit 6fe59d1
|
Current config file for commit 1f5085d: The Business as Usual scenario uses high circularitycosts.flags: scenario_parameters: data_directories: input_filenames: output_filenames: CostGraph must be re-initialized for any parameter changesto be reflected in the model.costgraph_parameters: pathway_parameters: discrete_event_parameters: |
Regarding the pathway "cost" history filename, it's now renamed as pathway_criterion_history in the config file, shortened to pathway_crit_history within the code itself. The "criterion" is thus whatever quantitative measure is used to decide between circularity pathways. Currently this is cost, for the wind turbine case study. The file itself has the following format: The column names now refer to "criterion" rather than "dist" (distance) which was causing confusing (it was a network distance over edges, not a transportation distance)
|
closed with pr #106 |
The text was updated successfully, but these errors were encountered: