-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Reorganize artifical data examples to make them easier to follow #117
Merged
paulf81
merged 13 commits into
NREL:develop
from
misi9170:enhancement/reorganize-examples
Aug 31, 2023
Merged
[Enhancement] Reorganize artifical data examples to make them easier to follow #117
paulf81
merged 13 commits into
NREL:develop
from
misi9170:enhancement/reorganize-examples
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the description to include the small polars bugfix |
paulf81
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @misi9170 , thank you! I pulled it down and tested examples and everything ran well, thank you!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review and possible merge.
Feature or improvement description
Some reorganization of the examples was needed for clarity. In particular,
These have now been addressed by
Related issue, if one exists
#113
Impacted areas of the software
examples_artifical_data/, examples_smarteole/, flasc (to a small extent)
Aditional notes
plot_energy_ratio()
from energy_ratio_output.py whenpolar_plot = True
.Test results, if applicable
Test pass after polars update