-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change nan behavior #121
Change nan behavior #121
Conversation
@misi9170 good to merge? |
@paulf81 I also made an unrelated to change to have the process of checking inputs to |
Looks great @misi9170, thank you! Merging |
Ready to be merged (maybe can delete some commented out lines)
Feature or improvement description
This pull request address Issue #119 , where we inadvertently changed nan filtering from an "Any" to an "All" in the conversion of energy ratio from pandas to polars. This pull requests fixes the convention back, and adds a test to confirm the expected behavior (and check going forward)
Related issue, if one exists
#119
Impacted areas of the software
energy_ratio.py
energy_ratio_output.py
energy_ratio_utiltities.py
energy_ratio_test.py