Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate layout visualization and power/thrust curve plots #32

Merged
merged 18 commits into from
Oct 26, 2022

Conversation

misi9170
Copy link
Collaborator

Breaking out the power and thrust curve plots form the layout plot to provide users with more flexibility. plot_floris_layout retains default behavior, but calls lower level functions. Also now allows for no labels to be printed on the layout plot (but providing turbine_names=[] to plot_floris_layout.

@paulf81
Copy link
Collaborator

paulf81 commented Oct 21, 2022

I think this is a big improvement @misi9170, thank you! I confirm I downloaded the code and ran examples that call the new split up functionality and it ran fine

I think though we could add just a little more to this pull request (I can help) my ideas our:

  • Add in the plotting functions currently in the feature/update_layout_vis branch of FLORIS (including inter-turbine distances and wake directions) as additional options
  • Make a new example (or example folder) showing different layout visualization options

@paulf81
Copy link
Collaborator

paulf81 commented Oct 21, 2022

Just wanting to connect this with project board and issue #34

@misi9170
Copy link
Collaborator Author

@paulf81 Sounds good, I'll work on incorporating those and creating an example.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@d1adcd3). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 3b5b98b differs from pull request most recent head 8e29892. Consider uploading reports for the commit 8e29892 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #32   +/-   ##
==========================================
  Coverage           ?   33.88%           
==========================================
  Files              ?       38           
  Lines              ?     3736           
  Branches           ?        0           
==========================================
  Hits               ?     1266           
  Misses             ?     2470           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@misi9170
Copy link
Collaborator Author

@paulf81 I've now updated this to incorporate a wake distances/directions plot and plots for yaw offset schedules. Both can be viewed by running examples/wake_steering_design/00_analyze_single_ws_v_range.py. I believe this is now ready to be merged.

@paulf81 paulf81 merged commit c679bfa into NREL:develop Oct 26, 2022
@paulf81
Copy link
Collaborator

paulf81 commented Oct 26, 2022

Merged!

@bayc bayc mentioned this pull request Oct 26, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants