Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(createFaceFromPoints): fix calculating intersectedFaces #364

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(createFaceFromPoints): fix calculating intersectedFaces #364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/store/modules/geometry/actions/createFaceFromPoints.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ export function newGeometriesOfOverlappedFaces(points, geometry) {
const geom = geometryHelpers.denormalize(geometry);
const intersectedFaces = geom.faces
.filter((face) => {
// handle unusual cases where face has no vertices
if (face.vertices.length === 0) {
return false
}
const inter = geometryHelpers.intersection(face.vertices, points);
// We care about faces have an intersection with the new one, or that
// cause errors (eg, split face) upon intersection
Expand Down