Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capabilities to parallel_floris_model #967

Merged
merged 7 commits into from
Aug 22, 2024

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Aug 21, 2024

#Add capabilities to parallel_floris_model

This pull request adds some capabilities to ParallelFlorisModel. These updates are not comprehensive, a more thorough updating of ParallelFlorisModel to provide full functionality of FlorisModel is deferred to a future pull request. The updates included in this PR are those necessary to support capabilities in FLASC's use of parallelized FLORIS runs. Specifically:

  • The set function's inputs are expanded to match the full set in FlorisModel
  • The method to run without wake (no_wake = True) is updated to the correct syntax of underlying FlorisModel
  • A new test of running without wake is added to confirm correct behavior
  • Functions for getting and setting operation model added
  • Functions for getting and setting parameters are added

A few remaining open questions:

  1. Some #TODO in the code mark a question (@misi9170 ) if a re-run of init is necessary / appropriate?
    (UPDATE: we decided to include init to be safe/consistent)
    Not doing this:
    3. I believe one more improvement we could make is add default values to max_workers, for example I think something like this code:

     ```
      if max_workers is None:
           max_workers = multiprocessing.cpu_count()
     ```
     
     Or maybe this can be out of scope of this PR
    

Impacted areas of the software

parallel_floris_model.py

@paulf81 paulf81 added the enhancement An improvement of an existing feature label Aug 21, 2024
@paulf81 paulf81 requested a review from misi9170 August 21, 2024 04:54
@paulf81 paulf81 self-assigned this Aug 21, 2024
@paulf81 paulf81 merged commit 1464208 into NREL:develop Aug 22, 2024
8 checks passed
@paulf81 paulf81 deleted the feature/update_pfm branch August 22, 2024 18:59
@misi9170 misi9170 mentioned this pull request Oct 7, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant