Add capabilities to parallel_floris_model #967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Add capabilities to parallel_floris_model
This pull request adds some capabilities to
ParallelFlorisModel
. These updates are not comprehensive, a more thorough updating ofParallelFlorisModel
to provide full functionality ofFlorisModel
is deferred to a future pull request. The updates included in this PR are those necessary to support capabilities in FLASC's use of parallelized FLORIS runs. Specifically:FlorisModel
no_wake = True
) is updated to the correct syntax of underlyingFlorisModel
A few remaining open questions:
Some
#TODO
in the code mark a question (@misi9170 ) if a re-run of init is necessary / appropriate?(UPDATE: we decided to include init to be safe/consistent)
Not doing this:
3. I believe one more improvement we could make is add default values to max_workers, for example I think something like this code:
Impacted areas of the software
parallel_floris_model.py