Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix most unit tests with Rust #187

Merged
merged 1 commit into from
Apr 25, 2023
Merged

fix most unit tests with Rust #187

merged 1 commit into from
Apr 25, 2023

Conversation

erik-hasse
Copy link
Contributor

This is still failing tests/test_simulationstate.py::TestSimulationState::test_terminal_state_starting_trip. The assertIsInstance on line 272 is failing because the vehicle stays in the ServicingTrip state

@nreinicke nreinicke self-requested a review April 25, 2023 20:25
nreinicke
nreinicke approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@nreinicke nreinicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for fixing all of those!

@nreinicke nreinicke merged commit db46e5d into NREL:explore-rust Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreinicke nreinicke nreinicke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erik-hasse @nreinicke