Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

117 adding kepler handler #188

Merged
merged 13 commits into from
Apr 25, 2023
Merged

Conversation

zenon18
Copy link
Contributor

@zenon18 zenon18 commented Apr 25, 2023

Completing issue #117 by adding a Kepler Handler that generates a kepler.json file that one can import into Kepler.gl

@zenon18 zenon18 marked this pull request as ready for review April 25, 2023 21:04
Signed-off-by: Mark W. <32108590+zenon18@users.noreply.github.com>
@jhoshiko
Copy link
Collaborator

Nice! Pulled these changes in and tested the results on kepler and everything seems to be working on my end. Curious to hear what @robfitzgerald thinks!

@zenon18
Copy link
Contributor Author

zenon18 commented Apr 25, 2023

kepler_example

Copy link
Collaborator

@robfitzgerald robfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, runs locally just fine for me. thanks for handling SimTime serialization along the way, the types and tests.

i did try dumping it straight into kepler and it does work but it's not obvious how i should play with the settings to get things to be pretty, i totally forget how i did that 🤦 but psyched now that we have this, i can get back to exploring that and we can get some nice ooos and aahhs when folks land on the readme.

thanks for all of your work, i hope you enjoyed figuring this one out!

@zenon18
Copy link
Contributor Author

zenon18 commented Apr 25, 2023

@robfitzgerald we noticed with the 1970's data you want to have the trailing length needs to be 1, we noticed the later data (say putting 2023 instead of 1970) you can use higher trailing lengths (like 180+)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants