Update development branch from master #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m lux value for each space type as per NECB
…or it in progress; Updated bundler version in openstudio-standards.gemspec
…ests to run. and only rake test:parallel_run_all_tests_locally
… 2015 in progress
Correcting Warehouse wall orientation
Including changes to use OS 3.5.1 and changes in master
…AP1980TO2010; Added units of min illuminance level to space_type_unit_definitions.txt; Added reference of min illuminance level to all space_types.json of necb
…Modified unit test for daylighting sensor control ecm and updated expected results for it
…ailstandalone, and smallhotel, due to changes in daylighting sensor control ecm
…condary school due to changes in daylighting sensor control ecm
…or controls ECM nrcan_375: modify daylighting sensor controls ECM
* replaced costing_enabled with intrinsic method to check if BTAPCosting is present * replaced costing_enabled with intrinsic method to check if BTAPCosting is present
Including changes in nrcan branch.
Variable for zone heating equipment in ECN HS12 was not properly set for DOAS
Removes model_system_outdoor_air_sizing_vrp_method(air_loop) and air_loop_hvac_apply_vav_damper_action(air_loop) methods from the default constructor for VAV systems. Instead, default to ZoneSum for the controller mechanical ventilation, and single maximum for VAV reheat terminals. Still apply these methods before the sizing run in the create PRM baseline and create prototype methods. Also, harmonize the outdoor air system setup between the VAV and PVAV archetypes.
may change to ventilation eventually
we anticipated it was placed in the wrong place, but it's changing the performance results.
…est-reporters v1.6.1.
Removing aws-sdk-s3 and git-revision gems not used in master
…_presets Implemented radiant control plant operation presets
Replace existing zone thermostat with constant thermostat to control radiant system
Fix/minitest version
remove VRP default in VAV constructor
Fix/hvac tests
add test helper for radiant system controls
restore 0.5 maximum reheat flow fraction
weilixu
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.