Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gb/rand axis layer #35

Merged
merged 5 commits into from
May 6, 2022
Merged

Gb/rand axis layer #35

merged 5 commits into from
May 6, 2022

Conversation

grantbuster
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022

Codecov Report

Merging #35 (d7ccac9) into main (2ada9d8) will increase coverage by 0.52%.
The diff coverage is 100.00%.

❗ Current head d7ccac9 differs from pull request most recent head b537dfb. Consider uploading reports for the commit b537dfb to get more accurate results

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   86.28%   86.81%   +0.52%     
==========================================
  Files          27       27              
  Lines        2684     2790     +106     
==========================================
+ Hits         2316     2422     +106     
  Misses        368      368              
Flag Coverage Δ
unittests 86.81% <100.00%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
phygnn/layers/custom_layers.py 82.81% <100.00%> (+2.81%) ⬆️
phygnn/version.py 100.00% <100.00%> (ø)
tests/test_layers.py 100.00% <100.00%> (ø)
tests/test_loss_metrics.py 100.00% <0.00%> (ø)
tests/test_tf_model.py 99.11% <0.00%> (+0.01%) ⬆️
phygnn/utilities/pre_processing.py 87.17% <0.00%> (+0.16%) ⬆️
phygnn/phygnn.py 89.47% <0.00%> (+0.28%) ⬆️
phygnn/layers/handlers.py 92.77% <0.00%> (+0.42%) ⬆️
phygnn/model_interfaces/random_forest_model.py 80.89% <0.00%> (+0.43%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ada9d8...b537dfb. Read the comment docs.

@grantbuster grantbuster force-pushed the gb/rand_axis_layer branch 2 times, most recently from f3cc58f to ab817a4 Compare May 6, 2022 15:49
Copy link
Collaborator

@bnb32 bnb32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me. not a huge pr.

@grantbuster grantbuster force-pushed the gb/rand_axis_layer branch 2 times, most recently from 400f217 to a017374 Compare May 6, 2022 16:02
@grantbuster grantbuster merged commit b993deb into main May 6, 2022
@grantbuster grantbuster deleted the gb/rand_axis_layer branch May 6, 2022 16:16
github-actions bot pushed a commit that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants