Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gb/bug mean ghi #106

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Gb/bug mean ghi #106

merged 2 commits into from
Feb 3, 2020

Conversation

grantbuster
Copy link
Member

Minor bug fix. added GHI as default retrieved variable in SAM resource handlers, as @MRossol suggested.

@grantbuster
Copy link
Member Author

@MRossol, can you review/approve/merge this? should be an easy PR.

MRossol
MRossol previously approved these changes Feb 3, 2020
Copy link
Collaborator

@MRossol MRossol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I foresee getting a resource file without GHI, but we can always compute it from DHI and DNI...

@MRossol
Copy link
Collaborator

MRossol commented Feb 3, 2020

Need to rebase

…used in SAM but should be available for mean calc. Extra read is not expected to slow down runs.
@grantbuster
Copy link
Member Author

@MRossol, rebased, can you approve and merge? Thanks!

Copy link
Collaborator

@MRossol MRossol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase done

@MRossol MRossol merged commit 0206497 into master Feb 3, 2020
@MRossol MRossol deleted the gb/bug_mean_ghi branch February 3, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants