Gb/output version #133
Merged
Gb/output version #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantbuster
commented
Mar 9, 2020
| mode = ['a', 'w', 'w-', 'x'] | ||
| if self._mode not in mode: | ||
| raise HandlerRuntimeError('mode must be writable: {}' |
There was a problem hiding this comment.
@MRossol, note that I removed this exception. Not sure why we raised an error here.
There was a problem hiding this comment.
No idea, probably changed the usage along the way and forgot to remove...
MRossol
requested changes
Mar 9, 2020
| mode = ['a', 'w', 'w-', 'x'] | ||
| if self._mode not in mode: | ||
| raise HandlerRuntimeError('mode must be writable: {}' |
There was a problem hiding this comment.
No idea, probably changed the usage along the way and forgot to remove...
reV/handlers/outputs.py
Outdated
|
|
||
| return True | ||
| writable = False | ||
| return writable |
There was a problem hiding this comment.
super nit-picky but can you add a line before the return for read-ability
There was a problem hiding this comment.
Done and also changed the temp var to is_writable so it doesn't look conflicted with the property/method name.
grantbuster
force-pushed
the
gb/output_version
branch
from
f05ebf6
to
25f67fd
Compare
MRossol
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.