Qa excl

[MRossol]

Add heatmap plots of final exclusions mask

Full pipeline test is in progress

[MRossol]

Full test ran, no wonder if died, the .npy file is 3.1 GB!

[grantbuster]

Nice! Looks good. If you have time, consider re-organizing the QAQC and Summarize classes to be more explicit on which file types they are handling. Theyre purposed for h5 files right now (gen, econ outputs) and have "hacks" to summarize supply curve and exclusions. Would be better to have abstract classes and concrete for applications to "normal" h5, exclusions, and sc. For example: QaQC.exclusions_mask(cls), this doesn't even use the cls arg? Seems like trying to fit a square peg in a round hole.

[MRossol]

Okay, @grantbuster let me know what you think. I heavily refactored summary, but only lightly changed QaQc. I kept just one QaQc class but reduced in init to just be out_dir, so its mainly just a set of staticmethods and classmethods to run QaQc on h5, sc, or excl

[grantbuster]

@MRossol, looks great. I agree its maybe a bit cumbersome with the multiple classes but the heirarchy is so much more obvious.

Any reason to run the test on Eagle again? Can you update the example pipeline config? Maybe add in the exclusion plot interval kwarg?

[MRossol]

I just re-ran the cli test and no issues. The only real excl kwarg would be point_step... I can change that to 200 or 1000 for the test?

[grantbuster]

@MRossol, yeah i more just think its nice to have in the example so anyone copying the example config knows its an options.

Can you add the exclusion block to the example file though? I just made a smaller standalone config for just the exclusions on Eagle and it never made its way to this file: https://github.com/NREL/reV/blob/qa_excl/examples/full_pipeline_execution/config_qa-qc.json

[MRossol]

I just came to the same conclusion when I went back to look at the example config. Just added the excl module to the example config from your eagle file