Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi File Resource Handling #41

Merged
merged 12 commits into from
Nov 12, 2019
Merged

Multi File Resource Handling #41

merged 12 commits into from
Nov 12, 2019

Conversation

MRossol
Copy link
Collaborator

@MRossol MRossol commented Oct 31, 2019

Update FiveMinWTK handler to new data format (in progress)
Add base MultiFileResource handler for NSRDB and FiveMinWTK

@MRossol
Copy link
Collaborator Author

MRossol commented Oct 31, 2019

TODO: Create tests for 5minWTK and 2018NSRDB

  • Need to create test data from 5min data

@MRossol MRossol changed the title Mnr/5min wtk Multi File Resource Handling Nov 1, 2019
@MRossol
Copy link
Collaborator Author

MRossol commented Nov 1, 2019

MutliH5 handler added to mimic h5py.File
MultiFileResource refactored to be compatible with all Resource functionality
NSRDB 2018 tests added
Will add FiveMinWTK tests ASAP

@MRossol
Copy link
Collaborator Author

MRossol commented Nov 3, 2019

Rebased on h5_exclusions to fix some merge conflicts that were going to happen in resource.py and test_handlers_resource.py. All tests pass after fixing conflicts

Copy link
Member

@grantbuster grantbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integrated into pipeline. Looks all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants