Gb/misc features #72
Merged
Gb/misc features #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MRossol
requested changes
Nov 26, 2019
There was a problem hiding this comment.
- create a log_memory function in loggers.py to replace the memory logging throughout reV:
log_memory(logger, level='DEBUG') - Update DatasetCollector to no longer use SmartParallelJob and instead transfer file by file, dataset by dataset with smart logic to check to see if the entire file/dataset can fit in memory, if not then transfer as many chunks as will fit in memory at a time until file/dataset has been transfered
…ods including smartparalleljob. Tests pass
…nks). Added test to make sure it works.
|
@MRossol, added those two features. Cleaned up collection a lot. Made a low memory test, although I realize now that this will be kind of hardware dependent. Still, works on my machine! |
MRossol
requested changes
Nov 27, 2019
| """ | ||
| Add results from SmartParallelJob to out | ||
| @staticmethod | ||
| def _get_site_mem_req(shape, dtype, n=100): |
There was a problem hiding this comment.
I'm confused is this the memory for one site, one chunk, or the whole dataset?
There was a problem hiding this comment.
Just for one site. I realize i forgot to update some of the docstrings. Fixed.
reV/handlers/collection.py
Outdated
| .format(os.path.basename(fp_source), e)) | ||
| raise e | ||
|
|
||
| def _low_mem_collect(self): |
There was a problem hiding this comment.
if this is the standard collection method I think we should rename it to just _collect
MRossol
reviewed
Nov 27, 2019
MRossol
approved these changes
Nov 27, 2019
|
Rebase and merge away |
This was referenced Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of four features:
Pytests added for all except 2 (which i tested manually on eagle).