Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offshore data bounds #107

Open
grantbuster opened this issue Apr 15, 2021 · 1 comment
Open

offshore data bounds #107

grantbuster opened this issue Apr 15, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@grantbuster
Copy link
Member

Bug Description

Bug to track offshore data input issues related to physical boundaries / limits.

Offshore input rules we have discovered:
1. Depth must be positive in meters
2. All distance columns have to be positive and > 0 (there are a lot of log(distance) operators in the nrwal equations)
3. All distance columns have to be in km (not meters!)
4. Hs_average must be > 0 (there are log(hs_average) operators in the nrwal equations)
5. fixed_downtime and floating_downtime are fractional and must be >0 and <1 (there are x/(1-downtime) operators in the nrwal equations)
6. Monopile eqns break down at large depth values (there is an exp(depth) operator in the monopile eqns)

@grantbuster grantbuster added the bug Something isn't working label Apr 15, 2021
@MRossol
Copy link
Collaborator

MRossol commented Apr 15, 2021

  1. fixed here:
    if layer == 'bathymetry':
    layer_out = np.abs(layer_out)
  2. fixed here:
    # exclude onshore pixels
    tech_map[self[offshore_dset] <= 0] = -1
  3. fixed here:
    elif layer == 'dist_to_coast':
    layer_out /= 1000
  4. fixed here:
    elif layer.startswith('weather_downtime'):
    layer_out[layer_out <= 0] = downtime_tolerance
  5. fixed here:
    if 'wave_height' not in layer:
    layer_out[layer_out >= 1] = 1 - downtime_tolerance
  6. Will need to be done in NRWAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants