Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace clusters_bins with capacity_bins #48

Merged
merged 7 commits into from
Mar 9, 2020
Merged

replace clusters_bins with capacity_bins #48

merged 7 commits into from
Mar 9, 2020

Conversation

MRossol
Copy link
Collaborator

@MRossol MRossol commented Mar 9, 2020

Implementation of #47
Replace cluster_sc_bins with capacity_bins

  • For each "resource"-"class" group create the given number of equal capacity bins, by default 3
  • Fill bins with cumulative capacity after sorting by the given column(s), by default "trans_cap_cost"

Misc:

  • config class updated
  • reeds_cli updated
  • example configs updated
  • tests updated

@MRossol MRossol added bug Something isn't working feature New feature or request labels Mar 9, 2020
@MRossol MRossol added this to Review in progress in reVX Dev via automation Mar 9, 2020
@MRossol
Copy link
Collaborator Author

MRossol commented Mar 9, 2020

fixes #50

reVX Dev automation moved this from Review in progress to Reviewer approved Mar 9, 2020
grantbuster
grantbuster previously approved these changes Mar 9, 2020
Copy link
Member

@grantbuster grantbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have time I would suggest doing a verification test by doing some mean/stdev on the classifier output equal capacity bins. This would basically be a sanity check on the outputs. Would serve to complement the baseline validation test. Not necessary if you're busy.

reVX Dev automation moved this from Reviewer approved to Review in progress Mar 9, 2020
@grantbuster grantbuster self-requested a review March 9, 2020 22:20
reVX Dev automation moved this from Review in progress to Reviewer approved Mar 9, 2020
@MRossol MRossol merged commit abfeb8d into master Mar 9, 2020
reVX Dev automation moved this from Reviewer approved to Done Mar 9, 2020
@MRossol MRossol deleted the reeds_bins branch March 9, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature or request
Projects
No open projects
reVX Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants