Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReEDS onshore wind rep profiles include offshore sites #50

Closed
mmowers opened this issue Mar 9, 2020 · 3 comments
Closed

ReEDS onshore wind rep profiles include offshore sites #50

mmowers opened this issue Mar 9, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@mmowers
Copy link
Collaborator

mmowers commented Mar 9, 2020

Bug Description
Certain onshore wind representative profiles actually correspond to offshore sites.

To Reproduce
See the 'meta' table of /shared-projects/rev/projects/reeds_jan2020/wind/onshore_wind/output/windons_hourly_cf.h5. Note that the rep_gen_gids for region 1, class 4-7 are offshore sites.

Expected behavior
Offshore wind data is filtered out and not included in onshore wind representative profiles

Screenshots
image

@mmowers mmowers added the bug Something isn't working label Mar 9, 2020
@MRossol
Copy link
Collaborator

MRossol commented Mar 9, 2020

Fixed in #48
There was a typo in the CLI that was not implementing the filter

@MRossol
Copy link
Collaborator

MRossol commented Mar 10, 2020

@mmowers I've re-run the on and offshore wind runs. Can you check to see if this is fixed (and if so close)?

@mmowers
Copy link
Collaborator Author

mmowers commented Mar 12, 2020

Looks good! Representative profiles now are reflecting onshore sites. Closing this issue.

@mmowers mmowers closed this as completed Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants