Simple bill calcs (enhancement) #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-robertson
added a commit
that referenced
this pull request
Feb 3, 2023
…9b56438 5c0bd9b56438 Merge pull request #1012 from NREL/additional-properties-updates 8fa43c9bb448 Update Changelog.md 2569aeb17804 Minor cleanup. Reverts EPvalidator.xml and docs changes. 39032492560d Latest results. 5717b02e84a1 Merge branch 'master' into additional-properties-updates eab2693294df Update description and docs. a0176f01e5cb Merge pull request #1010 from NREL/fix_timeseries_emissions 15dc8bc1f0b0 Latest results. 3961f4dfd771 Update Changelog.md [ci skip] 6e981e11bc0a Latest results. c8ea2273a98e Test more characters. dea7fa60c414 Latest results. ddc83ef99c93 Merge branch 'master' into additional-properties-updates b5d2f37c644f Fixes and updates to tear down method. 63df131dbb14 Add convenience method for retrieving additional properties. git-subtree-dir: resources/hpxml-measures git-subtree-split: 5c0bd9b5643882c90654364a6fa3528b36cf6afd
joseph-robertson
pushed a commit
that referenced
this pull request
Feb 3, 2023
a635749cb4 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os340 dd87b39af6 Try None strictness level. 5c0bd9b564 Merge pull request #1012 from NREL/additional-properties-updates 8fa43c9bb4 Update Changelog.md 2569aeb178 Minor cleanup. Reverts EPvalidator.xml and docs changes. b5bcd6d883 Merge branch 'os340' of https://github.com/NREL/OpenStudio-HPXML into os340 9b33a9b5f5 Remove battery warning. 3903249256 Latest results. 5717b02e84 Merge branch 'master' into additional-properties-updates eab2693294 Update description and docs. 54b4e02bab Latest results. 6e981e11bc Latest results. c8ea2273a9 Test more characters. dea7fa60c4 Latest results. ddc83ef99c Merge branch 'master' into additional-properties-updates b5d2f37c64 Fixes and updates to tear down method. 63df131dbb Add convenience method for retrieving additional properties. git-subtree-dir: resources/hpxml-measures git-subtree-split: a635749cb499e518cfb164246f18b8b1e26e5dcb
joseph-robertson
added a commit
that referenced
this pull request
Feb 3, 2023
…48fb6c9 9be6b48fb6c9 Merge pull request #1027 from NREL/foundation-floor-area fcb76b8aa1f0 Use new method throughout test. 89ecff3bb5e3 Add test for various foundations. 689cf5ff2086 Exclude garages from foundation floors. 62bf4d1d56ef Foundation slab could be at grade. d85026c649a1 Update the changelog. d7494630ba16 Update docs. c94657aa98f8 Update tests. cc7aa49ba455 Add new multiplier to measure and constants. 5c0bd9b56438 Merge pull request #1012 from NREL/additional-properties-updates 8fa43c9bb448 Update Changelog.md 2569aeb17804 Minor cleanup. Reverts EPvalidator.xml and docs changes. 39032492560d Latest results. 5717b02e84a1 Merge branch 'master' into additional-properties-updates eab2693294df Update description and docs. a0176f01e5cb Merge pull request #1010 from NREL/fix_timeseries_emissions 15dc8bc1f0b0 Latest results. 3961f4dfd771 Update Changelog.md [ci skip] 6e981e11bc0a Latest results. c8ea2273a98e Test more characters. dea7fa60c414 Latest results. ddc83ef99c93 Merge branch 'master' into additional-properties-updates b5d2f37c644f Fixes and updates to tear down method. 63df131dbb14 Add convenience method for retrieving additional properties. git-subtree-dir: resources/hpxml-measures git-subtree-split: 9be6b48fb6c978358cc8e942001ac2b2a9586eae
ekpresent
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
@joseph-robertson walked me through the capabilities today. These will be very useful and I appreciate the presence of reasonable defaults when there is a missing bill specification. We are planning to test as part of the LARGEEE run if we can merge it quickly to the appropriate branch.
Note that at some point in the future we will probably need/want to be able to have multiple dependencies for utility rates - a key example being the intersection of geography (e.g. state) and EV presence.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #890.
Add optional
simple_filepathyml argument for pointing to user-specified TSV file of utility rates. The TSV file can contain utility rates mapped by State, or any other parameter.Test the new optional
simple_filepathyml argument in the testing projects, under additionalBills2(resources/data/simple_rates/State.csv) andBills3(resources/data/simple_rates/County.csv) scenarios.Checklist
Not all may apply:
openstudio tasks.rb update_measureshas been run